OK, But i am building the

benf — Wed, 23 Jul 2008 09:44:02 +0000

OK,
But i am building the error message and putting it in $error if $error has something in it i return false.
On the page that calls the method insert checks to see if it is returning false (has some errors) if it does it prints out $error.

I then dont want the method Insert to run any further past the error so i exit the scipt?

Is this incorrect?

The method you posted never

pr0gr4mm3r — Mon, 21 Jul 2008 13:43:59 +0000

The method you posted never prints anything. It just returns an error message if something goes wrong.

Also, in this code:

<?php
if($this->error != ""){           
return FALSE;
exit(0);           
} 
?>

exit(0); will never run because the return statement is above it, and once you return, the method is over.

I build the Error variable

benf — Mon, 21 Jul 2008 09:04:12 +0000

I build the Error variable and call it on the main page from $this->error if the method returns false - this prints the error messages?

I will have another look then.

Are you sure you're not

pr0gr4mm3r — Mon, 21 Jul 2008 02:12:47 +0000

Are you sure you're not calling the method more than once? I know it sounds too simple, but there is no way the code you posted would run twice unless you called the method twice.

Another possibility. I see that you append $this->error, but I don't see where it is declared. If you are saving/restoring that variable from a session, then you could be building and copying error messages as you test.

If you read my last post

greg — Sun, 20 Jul 2008 19:27:00 +0000

If you read my last post before I removed what I wrote then my apologies. I re-read your code and realised what the second array you made was doing.

something I noticed unrelated to the error you have an issue with..

<?php
foreach ($data as $field => $value)

if (in_array($field, $data_fields))
     {
         $fields .= "`$field`,";
         $values .= "'" . mysql_real_escape_string($value, $this->dbconnection()) . "',";
                    }
?>

If the value of $field isn't in the array $data_fields, then it wont be sanitised by real_escape.
Perhaps some of the data in the $data array doesn't need filtering, and you have already checked the data on a previous page to ensure it's ok to enter into the db I.E. no apostrophes or quotes etc.
Otherwise it's a potential to NOT sanitise data that might need to be for security.

As for your initial problem, within the code you provided (the function) I see no reason whatsoever why it would echo the error twice.
I have to go out atm, but if you or no-one else has found the error or put you on the right track I'll have another look later.

Sorry greg, im not sure i

benf — Sun, 20 Jul 2008 18:37:21 +0000

Sorry greg, im not sure i understand?

Edited as was incorrect

greg — Sun, 20 Jul 2008 18:13:00 +0000

Edited as was incorrect findings

Yes this is what i did: in

benf — Sun, 20 Jul 2008 17:42:57 +0000

Yes this is what i did:

in place of the below

            if($this->error != ""){           
                return FALSE;
                exit(0);           
            } 

i changed to this:

            if($this->error != ""){  
                $this->error .=$i++;         
                return FALSE;
                exit(0);           
            } 

i being declared at the top of my script as 0. The result appended 0 then 1 to the end of each set of errors - for example

please enter an email address
please confirm your password
0

please enter an email address
please confirm your password
1

the example above you can see 0 then 1.
I have exited the script so really nothing below it should be executing, and above there is no loop?

troubleshoot the flow add

decibel.places — Sun, 20 Jul 2008 16:59:11 +0000

troubleshoot the flow

add echo "step1 "; and echo "step2 "; etc.

or echo "<script>alert('step1')</script>";

to see where it breaks down - you could also add variables if that helps...

Hi thanks for the quick

benf — Sun, 20 Jul 2008 16:41:47 +0000

Hi thanks for the quick reply.

I dont think i have been clear enough. Not a php error;my own error detection - ie...email address not filled in, passwords do not match.

If you look i check to see if the variable error has anything in it, if it does then i return false and exit().

Trouble is that what ever errors i pick up are printed twice?