Excellent! Thanks for that

drew22299 — Wed, 26 Mar 2008 20:52:04 +0000

Excellent! Thanks for that both of you I really will have to research and use PHP more because I'm guessing that's a simple thing to do with PHP lol

Quote: I don't even think

pr0gr4mm3r — Wed, 26 Mar 2008 20:29:34 +0000

Quote: I don't even think mysql_error() will show anything unless you make a syntax error in your queries.

It will show other errors such as duplicate key fields, unknown columns, etc. Still, should not be shown to the end user.

mysql_query() returns TRUE

teammatt3 — Wed, 26 Mar 2008 19:57:19 +0000

mysql_query() returns TRUE (well, a resource, but it's still true) on all valid select queries even if the select query doesn't return any rows. So using that to test if a user name is already in use is no good. As long as the query syntax is correct, it returns true.

You need to do something like

<?php
$sql2 = \"SELECT COUNT(*) AS Cnt FROM `users` WHERE username='$username'\";
$result2 = mysql_query($sql2);
$row = mysql_fetch_assoc($result2);
$cnt = $row['Cnt'];

if($cnt > 0){
...
?>

You run a query that counts how many rows contain that username. Fetch it and check if the fetched result row contains a cnt (short for count) that is greater than 0.

Make sense?

PS mysql_error() is not a very good message to show to your users . I don't even think mysql_error() will show anything unless you make a syntax error in your queries.