Greg ok. Thanks for the help

benf — Wed, 05 Mar 2008 16:21:02 +0000

Greg ok. Thanks for the help but i did this - tell me what you think.

<?php
        function phparticles($id){
            $phparticle = \"select * from smf_messages where
                                       ID_BOARD='$id'\";
            $query = $this->query($phparticle);
            while($getarticle = $this->fetchArray($query)){
                $articledata .= \"<a href=\\"article.php?id=\".$getarticle[0].\"\\">\".$getarticle[6].\"</a>
<br />\";
            }
            return $articledata;
        }
?>

So id is the id of the topic type or board etc that i want to use so i can reuse this function for all article types. I can add another parametre such as the limit if i need to!

Try this

Greg K — Wed, 05 Mar 2008 15:13:25 +0000

Try this instead:

$articledata = array();
while($thearticle = $this->fetchArray($php)){
  $articledata[] = $thearticle;
}
return $articledata;

Now the returned value will be an array of all the row results. NOTE: I'm not sure what all fields/data your table consists of, but would recommend only selecting the field you want (ie. title, body, author, date etc).

ie. maybe do the following, assuming the fields given as an example above:

function phparticles($field = 'body', $limit=0) {
  $fields = array('title','body','author','date'); // If in class, set with other class varaiable
  if (!in_array($field,$fields))
    die ("Invalid Call to function.");
  $limit = strval($limit); // Makes sure it is a number
  $results = array();
  	  	
  $sql = "SELCET `" . $field . "` FROM `smf_messages` WHERE `ID_BOARD`='26'";
  if ($limit > 0)
    $sql .= " LIMIT " . $limit;
  	
  $dbResult = $this->query($sql);
  
  while($results[] = $this->fetchArray($dbResult));
	
  return $results;
}

This now lets you specify what field you want to use less resources to get what you actually want, (defaults to body of the message) and optionally allows you to limit how many it is getting (hopefully you will grow to have tons of posts , so maybe you only want to display the last 10...

Anyhow, just some thoughts and not 100% sure what you are looking for.

-Greg