resolved

Mr. J — Fri, 23 Nov 2007 18:40:54 +0000

A buddy of mine from Indiana resolved this issue in about ten minutes. In case anyone's interested, the below code works perfectly.

Thanks

<?php
$tomail = $_POST[\"friend_1\"];

$from = $_POST[\"sender_email\"];
$copyfrom = $_POST[\"sender_email\"];
$notifyMail = \"contact@mywebsite.com\";

// Check the email address
if(!preg_match('/^[^@\s<&>]+@([-a-z0-9]+\.)+[a-z]{2,}$/i', $from)) {
$errormessage = \"Your e-mail address is invalid!\";
}

if(!preg_match('/^[^@\s<&>]+@([-a-z0-9]+\.)+[a-z]{2,}$/i', $_POST[\"friend_1\"])) {
$errormessage .= \" Your 1st friend's e-mail address is invalid!\";
}
if(!preg_match('/^[^@\s<&>]+@([-a-z0-9]+\.)+[a-z]{2,}$/i', $_POST[\"friend_2\"]) && $_POST[\"friend_2\"]) {
$errormessage .= \" Your 2nd friend's e-mail address is invalid!\";
}
if(!preg_match('/^[^@\s<&>]+@([-a-z0-9]+\.)+[a-z]{2,}$/i', $_POST[\"friend_3\"]) && $_POST[\"friend_3\"]) {
$errormessage .= \" Your 3rd friend's e-mail address is invalid!\";
}
if(!preg_match('/^[^@\s<&>]+@([-a-z0-9]+\.)+[a-z]{2,}$/i', $_POST[\"friend_4\"]) && $_POST[\"friend_4\"]) {
$errormessage .= \" Your 4th friend's e-mail address is invalid!\";
}
if(!preg_match('/^[^@\s<&>]+@([-a-z0-9]+\.)+[a-z]{2,}$/i', $_POST[\"friend_5\"]) && $_POST[\"friend_5\"]) {
$errormessage .= \" Your 5th friend's e-mail address is invalid!\";
}

if (!$errormessage) {

if (!empty($_POST[\"sender_email\"]))
{
$from = \"From: \" . $your_email . \"\nContent-type: text/html\n\";
} else {
$from = \"From: contact@mywebsite.com\nContent-type: text/html\n\";
$your_email = \"contact@mywebsite.com\";
}

$notifyMail = \"contact@mywebsite.com\";
$notifySubject = \"TV webcasts Was Shared from mywebsite.com\";
$notifyMessage = \"The send video script was just used for:\r\n\r\n\";
$notifyMessage .= \"Live Streaming TV Webcasts\r\n\";
$notifyMessage .= \"http://www.mywebsite.com/live-webcasts/\r\n\r\n\";
$notifyMessage .= \"Recipient Email: \" . $tomail . \"\r\n\r\n\";
$notifyMessage .= \"Sender: \" . $_POST[\"sender_name\"] . \"\r\n\";
$notifyMessage .= \"Sender Email: \" . $_POST[\"sender_email\"] . \"\r\n\";
$notifyMessage .= \"Message: \" . $_POST[\"extra\"] . \"\r\n\r\n\r\n\";
$notifyMessage .= \"* Complete strangers are promoting mywebsite.com.\";

//copy to sender
$copyfrom = \"From: \" . $_POST[\"sender_email\"] . \"\";
$copyMail = $_POST[\"sender_email\"];
$copySubject = \"You sent TV webcasts from mywebsite.com\";
$copyMessage = \"*Below is a copy of the email(s) you sent:\r\n\r\n\r\n\";
$copyMessage .= \"When you have a moment, check out these online TV webcasts.\r\n\r\n\";
$copyMessage .= \"Live Streaming TV Webcasts\r\n\r\n\";
$copyMessage .= \"http://www.mywebsite.com/live-webcasts/\r\n\r\n\r\n\";
$copyMessage .= $_POST[\"extra\"] . \"\r\n\r\n\r\n\";
$copyMessage .= $_POST[\"sender_name\"] . \"\r\n\r\n\r\n\r\n\";
$copyMessage .= \"________________________________________\r\n\";
$copyMessage .= \"Sent courtesy of: http://www.mywebsite.com/\r\n\r\n\";
//end of copy email

//main message
$from = \"From: \" . $_POST[\"sender_email\"] . \"\";
$subject = \"Check out these online TV webcasts...\";

//email format - plain jane text
$inputMessage .= \"Hi,\r\n\r\n\";
$inputMessage .= \"When you have a moment, check out these online TV webcasts.\r\n\r\n\";
$inputMessage .= \"Live Streaming TV Webcasts\r\n\r\n\";
$inputMessage .= \"http://www.mywebsite.com/live-webcasts/\r\n\r\n\r\n\";
$inputMessage .= $_POST[\"extra\"] . \"\r\n\r\n\r\n\";
$inputMessage .= $_POST[\"sender_name\"] . \"\r\n\r\n\r\n\r\n\";
$inputMessage .= \"________________________________________\r\n\";
$inputMessage .= \"Sent courtesy of: http://www.mywebsite.com/\r\n\r\n\";
//end of email

//send the email
for ($x = 1; $x <= 5; $x++)
mail ($_POST[\"friend_$x\"], $subject, $inputMessage,$from);

//mail ($notifyMail, $notifySubject, $notifyMessage);
if ($_POST[\"copyMail\"]) {
mail ($copyMail, $copySubject, $copyMessage, $copyfrom);
}
}

<html>
<head><title>thank you page</title></head>
<body>
thank you page text
</body>
</html>
?>

calculator — Thu, 22 Nov 2007 23:04:37 +0000

Your email checking function is a bit too 'messy'. Why would you try and replace invalid characters? If someone enters one, simply throw an error at them and ask them to modify their it.

I would use something like the following regular expression to test email validity (inspired by the book essential PHP security from Chris Shifflet):

if(preg_match('/^[^@\s<&>]+@([-a-z0-9]+\.)+[a-z]{2,}$/i', $thisEmail)){
  //email is ok
}else{
  //email invalid
}

Greg K — Thu, 22 Nov 2007 22:41:21 +0000

Just quick suggestion.

Name all the TO fields the same (say sender_email[]

Now you will have an array in PHP, , ex. $_POST['sender_email'][0], $_POST['sender_email'][1], $_POST['sender_email'][2]

Break you code up so it does all the checking of the info that will be the same on every e-mail (sender's e-mail, setting up the actual message and headers, etc). Then do a loop, simliar to the following:

foreach ($_POST['sender_email'] as $thisEmail)
{
    // VALIDATE THE E_MAIL ADDRESS HERE, the current e-mail is in $thisEmail

    // SEND THE E_MAIL HERE
}

'
You will probably want to ad checking on each one to make sure each of them actually validate good.

Just a rough solution for you, normally I'd et more detailed, but kinda tired today.

-Greg