teammatt3 — Fri, 09 Nov 2007 15:47:19 +0000

Quote: It's constantly running the same query over and over, without an end. You need to get the result from a mysql_query call and pass it to something like mysql_fetch_assoc().

Yeah, that makes sense. I thought because I returned the results of mysql_fetch_assoc it would use that, but each time through the loop it re-runs the query, producing the exact same associative array each time. Got it.

Quote: I can post actual code of what I am talking about once I get it written.

I'd like that, because I really don't know what I'm doing

JeevesBond — Tue, 06 Nov 2007 19:13:17 +0000

<?php
while($row = $db->query(\"SELECT * FROM User WHERE UserID = 9 OR UserID = 4\"))
?>

The problem is in this line. Look at it closely and think what it's doing (it might help to cross your legs and make Yoga-like Ommmmmmmm noises at this point).

It's constantly running the same query over and over, without an end. You need to get the result from a mysql_query call and pass it to something like mysql_fetch_assoc().

Matt wrote: Any ideas of what else should go in a DB object? I should look through some CMSs and see what they do...

Being a Drupal fan-boy I'll point you at their solution, they have a thin database abstraction layer (it's not done with objects, but it is object orientated-ish).

pr0gr4mm3r — Tue, 06 Nov 2007 18:42:19 +0000

I've been working on something like this as well. I've been working on it as a side note, so I haven't gotten that far.

I figure to have one class per table in a database and have each table class inherit a main database class. The main database class can handle global stuff like connections and also methods for raw queries and such. The table can have more table-specific methods. For example, if I have a table of registered site users, I would have table methods like AddUser(), RemoveUser(), changePassword(), etc. My goal is to completely remove raw SQL queries from my main code. Replacing raw queries with custom methods like that allows you to tweak your SQL queries for the whole website and even make it relatively easy to migrate to a different SQL database system like PrestegeSQL or something similar if needed.

I can post actual code of what I am talking about once I get it written.

teammatt3 — Tue, 06 Nov 2007 15:18:18 +0000

Yeah, realized that. For example what if the query is just an update query and I don't need to fetch anything? When I was testing I was just running select queries, I didn't even think about updating, inserting or deleting.

Any ideas of what else should go in a DB object? I should look through some CMSs and see what they do...

I probably need a result counter with mysql_num_rows and one for mysql_affected_rows too.

kaykays — Tue, 06 Nov 2007 11:31:44 +0000

IMO, your logic is not correct. You are currently repeatedly calling the function to run the query.

I think you require three functions:

1) Connect - this is ok

2) Query - Just to run the query

3) Fetch - To return the results.

Connect and Query should be run once before the while loop.

Fetch should be run as the while condition.