JeevesBond — Fri, 03 Aug 2007 17:36:32 +0000

This is the problem:

<?php
return $fetch;
?>

return means: stop whatever you're doing and return a result. This code will only ever reach the first row. I would advise against building an array containing the entire resultset of a query, you'll probably get out of memory errors in PHP. Generally it's better to keep the resultset with the database server and request one line of the result at a time, much more efficient! If you really need to do it that way though, try:

<?php
function test() { 
  $test = new database(); 
  $query = $test->query(\"SELECT * FROM table\"); 

  while ($fetch = $test->fetcharray($query)) { 
    $all_fetches[] = $fetch;
  }
  return $all_fetches; 
}
?>

It's certainly desirable to abstract database connectivity though, particularly if you're planning on supporting multiple database backends (MySQL, PostgreSQL, MS SQL Server etc.) so your idea is a good one.