CptAwesome — Tue, 22 Mar 2005 07:02:08 +0000

Yeah, I suppose that makes sense.

Renegade — Tue, 22 Mar 2005 03:51:35 +0000

Well, yes, I could do it that way, but the thing is, this way, it is more dynamic. As in, I can just query for a "cid", "csurname", and "cfirstname" and show those then, call the function again to show "cid", "csurname", "cfirstname" and "cemail"

...Get it?

CptAwesome — Mon, 21 Mar 2005 19:33:27 +0000

putting it in a function is ok, but it's the for loop that confuses me, I mean, you could just have it echo one TD at a time, and you'd only have an extra couple lines.

Renegade — Mon, 21 Mar 2005 19:13:27 +0000

CptAwesome wrote: To be honest, I don't know why you'd bother with a for loop, an extra few lines of code would save you this headache. But I am pretty sure, the following would do the trick:

Yes, the code did work. Thanks.

The reason I do it this way is because I want to show the table of contacts on several pages and it would save a lot of time and recoding if I just put it into a function and made it more "generic"

CptAwesome — Mon, 21 Mar 2005 17:20:51 +0000

To be honest, I don't know why you'd bother with a for loop, an extra few lines of code would save you this headache. But I am pretty sure, the following would do the trick:

function fnBrowse($result) { 
      while($line = mysql_fetch_array($result)) { 
          echo "<tr>"; 
          for($i = 0; $i <= ((count($line) / 2) - 1); $i++) { 
              echo "<!-- line $i -->"; 
	if($line[$i] == $line[cemail]){
	              echo "<td><a href=\"mailto:" . $line[$i] . "\">". $line[$i] . "</a></td>"; 
		}
	if($line[$i] == $line[cwebsite]){
	              echo "<td><a href=\"" . $line[$i] . "\">". $line[$i] . "</a></td>"; 
		}
              echo "<td>" . $line[$i] . "</td>"; 
            } 
          echo "</tr>\n"; 
        } 
    } 

Renegade — Mon, 21 Mar 2005 10:56:36 +0000

OK, I'm looping through and outputting the result using this function:

<?php
  function fnBrowse($result) {
      while($line = mysql_fetch_array($result)) {
          echo \"<tr>\";
          for($i = 0; $i <= ((count($line) / 2) - 1); $i++) {
              echo \"<!-- line $i -->\";
              echo \"<td>\" . $line[$i] . \"</td>\";
            }
          echo \"</tr>\n\";
        }
    }
?>

Problem is, how do I check if the current line is "cemail" or not? I want that so that I can make it into a link. The same for "cwebsite".

Renegade — Mon, 21 Mar 2005 00:58:28 +0000

Problem solved. Turned out that I was trying to free a result which didn't exist. Should have read the manual more carefully - http://nz.php.net/manual/en/function.mysql-query.php

Quote:
For SELECT, SHOW, DESCRIBE or EXPLAIN statements, mysql_query() returns a resource on success, and FALSE on error.

For other type of SQL statements, UPDATE, DELETE, DROP, etc, mysql_query() returns TRUE on success and FALSE on error.

Since I was using an INSERT query, it was returning a "1" instead of an actual resource ID so there was nothing to free.

dk01 — Sat, 19 Mar 2005 04:54:27 +0000

I would try this instead. Results return an object memory address no matter if any results were found. Instead use mysql_num_rows($result) like so:

<?php
mysql_connect($host, $user, $pass) or die(\"Unable to connect to database: \" . mysql_error());
  mysql_select_db($database) or die(\"Unable to select database: \" . mysql_error());

  if($_POST['action'] == \"add\") {
      $query = \"INSERT INTO \" . $table . \"(cid, csurname, cfirstname, cdob, csex, caddress, csuburb, ccity, ccountry, cphone, cmobile, cemail, cwebsite) VALUES('', \"
              .\"'\" . trim($_POST['add_surname']) . \"', \"
              .\"'\" . trim($_POST['add_firstname']) . \"', \"
              .\"'\" . trim($_POST['add_dob']) . \"', \"
              .\"'\" . trim($_POST['add_sex']) . \"', \"
              .\"'\" . trim($_POST['add_address']) . \"', \"
              .\"'\" . trim($_POST['add_suburb']) . \"', \"
              .\"'\" . trim($_POST['add_city']) . \"', \"
              .\"'\" . trim($_POST['add_country']) . \"', \"
              .\"'\" . trim($_POST['add_phone']) . \"', \"
              .\"'\" . trim($_POST['add_mobile']) . \"', \"
              .\"'\" . trim($_POST['add_email']) . \"', \"
              .\"'\" . trim($_POST['add_website']) . \"');\";
      echo $query . \"<br />\";
      $result = @mysql_query($query);
      if(mysql_num_rows($result)>0) {
          echo \"No result: \" . mysql_error();
        }
      else {
          while ( $row = mysql_fetch_array($result) ){ 
          echo($row['FIELD TO DISPLAY HERE']);
        }
        mysql_free_result($result);
    }

  mysql_close();
?>

edit :// You were also trying to print a result. Instead you have to print a field. Try the code above but try entering one of the fields you want to display instead of FIELD TO DISPLAY HERE.

Hopefully that solves it.

-dk

Renegade — Sat, 19 Mar 2005 03:34:26 +0000

I get this error:

Warning: mysql_free_result(): supplied argument is not a valid MySQL result resource in c:\phpdev\www\public\contacts\content\add.php on line 23

<?php
  mysql_connect($host, $user, $pass) or die(\"Unable to connect to database: \" . mysql_error());
  mysql_select_db($database) or die(\"Unable to select database: \" . mysql_error());

  if($_POST['action'] == \"add\") {
      $query = \"INSERT INTO \" . $table . \"(cid, csurname, cfirstname, cdob, csex, caddress, csuburb, ccity, ccountry, cphone, cmobile, cemail, cwebsite) VALUES('', \"
              .\"'\" . trim($_POST['add_surname']) . \"', \"
              .\"'\" . trim($_POST['add_firstname']) . \"', \"
              .\"'\" . trim($_POST['add_dob']) . \"', \"
              .\"'\" . trim($_POST['add_sex']) . \"', \"
              .\"'\" . trim($_POST['add_address']) . \"', \"
              .\"'\" . trim($_POST['add_suburb']) . \"', \"
              .\"'\" . trim($_POST['add_city']) . \"', \"
              .\"'\" . trim($_POST['add_country']) . \"', \"
              .\"'\" . trim($_POST['add_phone']) . \"', \"
              .\"'\" . trim($_POST['add_mobile']) . \"', \"
              .\"'\" . trim($_POST['add_email']) . \"', \"
              .\"'\" . trim($_POST['add_website']) . \"');\";
      echo $query . \"<br />\";
      $result = mysql_query($query);
      if(!$result) {
          echo \"No result: \" . mysql_error();
        }
      else {
          echo $result;
          mysql_free_result($result);
        }
    }

  mysql_close();
?>

Strange thing is, when I copy and paste the output of $query into phpmyadmin, it will add the row just fine...

...I don't get all this database stuff :S

Greg K — Fri, 18 Mar 2005 21:16:28 +0000

The more important reason to inlcude all column names is that way if you ever change the table structure later (like add or delete columns), you are not dependant on the order.

To clarify, the error you are receiveing is becasue the # of items you are inserting into the table does not match the number of columns in the table. (I've done this before).

As you are indicating you will liekley have more SQL questions, I would offer this tip. When possible if you have a problem test the actual SQL command by hand either by logging into mySQL thought a shell account, or use something like phpMyAdmin where you can directly issue the SQL command. Sometimes this will geive you a better error message and help you narrow down the problems. To aid in doing this, on the line of code where you issue the mysql_query, right before it echo out the actual SQL statement. (this has helped me many times figure out i missed a quote or a coma).

Also in reference to phpMyAdmin, until you are used to it, this can help you properly format the php code you need, as there is a link after you execute commands for "show PHP code" (If i remember right, you do need to adjust the code that is given to have some spaces at the ends of the line, may be fixed now).

Yes I like phpMyAdmin, that and Zend Studio are two of my fav tools for php programming.

-Greg

PS. to Cpt: I had the reply all written, just got delayed in hitting send becasue my lady come to visit. Idea for the system: if you from when you hit REPLY till when you hit SEND/POST, if it detects there has been a new reply, let you know before accepting post.