Vincent Puglia — Wed, 26 Nov 2003 01:42:29 +0000

Hi,

if you send a boolean along with the id, you can simplify the code even further:

function ShowHide(divID, showIt )
{
document.getElementById("IMG_"+divID).style.src = (showIt) ? "images/minus1.gif" : "images/plus1.gif";
document.getElementById(divID).style.display = (showIt) ? "block" : "none";
}

Vinny

necrotic — Sun, 23 Nov 2003 19:48:28 +0000

I forgot that display: none made it actually display nothing. I'm used to visibility: hidden which just hides it and still keeps the spacing. Thanks again.

Abhishek Reddy — Sun, 23 Nov 2003 04:54:44 +0000

No problems. It's pretty much what you had before, but without the frills. Sometimes we complicate things too much. Took me a while to realise that I was overlooking the positioning bit.

necrotic — Sun, 23 Nov 2003 03:18:50 +0000

Wow, that's great! Thanks so much Abhi!

Abhishek Reddy — Sun, 23 Nov 2003 01:03:07 +0000

Check this out.

necrotic — Sat, 22 Nov 2003 17:04:34 +0000

Actually, I did change the path to ../images/. Strange stuff.

In opera 6 it doesn't work at all. IE the same problem exists. Mozilla it works fine. What I'll probably end up doing is having the javascript only on Mozilla. For IE and Opera it'll just be automatically opened (PHP most likely, I'm better at that).

Thanks for the help Abhishek!

Abhishek Reddy — Fri, 21 Nov 2003 03:22:34 +0000

It works in Mozilla Firebird 0.7 on Linux. Only think is that the images don't change, but that's because you haven't altered the paths for your own filing structure. What browers does it fail in?

Good luck on that project, sounds like a lot of work.

necrotic — Fri, 21 Nov 2003 00:57:52 +0000

It works in IE, but the same problem exists. I'd look at it closer, but I have to do a project for school now. It's a large one, too. Doing a pixel art of a Manor from Medieval Times. Fun stuff, but hard. Thanks for the help.

Abhishek Reddy — Thu, 20 Nov 2003 06:47:18 +0000

It's already & copy ;? That means my editor is parsing HTML character code. Or maybe it was Mozilla while saving the page. Sorry about that.

Tell me if that code works right in IE. I have no idea what IE's support of DOM/ECMA standards is like anymore.

necrotic — Thu, 20 Nov 2003 02:37:38 +0000

Abhishek Reddy wrote:
<?php <script type=\"text/javascript\">  </script> ?>

Works in Mozilla Firebird. To make life a little easier, you might want to code to xhtml strict or transitional. Helps with the DOM sometimes. Also use & copy ; instead of the copyright character at the bottom.

Oh, and change paths to suit.

Already is & copy ;.

I'll try that code, thanks.