Mark Hensler — Sat, 15 Mar 2003 07:57:53 +0000

<?php
PHP

$file = \"data/$pagename.txt\";

if (isset($_POST[pagedit])) {
    $post = $_POST[pagedit];
    $fp = fopen($file, 'w+');
    if ($fp) {
        fwrite($fp, $post);
        fclose($fp);
    }
}


<form action=\"= $PHP_SELF \" method=\"POST\">
<textarea name=\"pagedit\" cols=\"45\" rows=\"10\">

    readfile($file);

</textarea><br>
<input type=\"submit\" name=\"submit\" value=\"Save Changes\">
</form>
?>

$file = "data/$pagename.txt";
Must use double quotes, or else $pagename will not be expanded.
Same thing for $post = $_POST[pagedit];

PHP Docs:
readfile()

nike_guy_man — Sat, 15 Mar 2003 03:06:39 +0000

You learn something new every day, dontcha?
I'm not sure if I understand the concept of this script, but here's my shot at a rewrite

<?php
PHP
if (isset($_POST[pagedit])) {
$post = '$_POST[pagedit]';
$file = 'data/$pagename.txt';
$fp = fopen($file, 'w+');
fwrite($fp, $post);
fclose($fp);
}
$file = 'data/$pagename.txt';
$fp = fopen($file, 'r');
$contents = fread ($fp, ($file));



<form action=\"=$PHP_SELF \" method=\"POST\">
<textarea name=\"pagedit\" cols=\"45\" rows=\"10\">
=$contents 
</textarea><br>
<input type=\"submit\" name=\"submit\" value=\"Save Changes\">
</form>
?>

First visit puts the form up with the current contents
Once submitted, it updates the file and reprints the form
However, you have $file = 'data/$pagename.txt' Where does $pagename come from? That's also not clean code
You had fopen ($file, 'w+') which is for writing, you needed fopen ($file, 'r')
Make sense?
I'm sure I made some stupid mistake in my fix there, but I cleaned it up a lot!

Renegade — Sat, 15 Mar 2003 01:35:56 +0000

Cool, never knew that

zollet — Fri, 14 Mar 2003 19:49:54 +0000

Yeah

Suzanne — Fri, 14 Mar 2003 18:34:19 +0000

hot damn!

zollet — Fri, 14 Mar 2003 18:24:24 +0000

<?= basically means echo/print. Here are some other examples how it could be used..

<?= "Hello World!" ?>
<?= "Your name is: " . $name ?>
<?= 3 * 5 ?>
<?= phpinfo() ?>

etc...

Suzanne — Fri, 14 Mar 2003 16:24:07 +0000

really? didn't know that, nifty!

zollet — Fri, 14 Mar 2003 14:35:02 +0000

You don't need the ; if you're using <?= $var ?>

Renegade — Fri, 14 Mar 2003 10:05:00 +0000

Quote: Originally posted by necrotic

<?php <form action=\" PHP_SELF \"> ?>

should be

<?php <form action=\" echo $PHP_SELF; \"> ?>

Or if your lazy...

<?php
<form action=\"=$PHP_SELF;\">
?>

zollet — Fri, 14 Mar 2003 06:49:00 +0000

Hmm... that piece of code is no good. There are too many errors and it doesn't even make sense. What exactly are you trying to do theyapps?