killmaster — Wed, 24 Apr 2002 08:09:55 +0000

thanks im busy tonight so I can't try that but I have thursday, friday and the weekend of to try everything out then.

Will let you know hoiw it works out

thanks

Mark Hensler — Tue, 23 Apr 2002 18:47:43 +0000

That doesn't look like a correct SQL statement.

Try this:
CREATE TABLE messages(id int(11) DEFAULT 1 AUTO_INCREMENT PRIMARY KEY, poster TEXT, headline TEXT, time TEXT, message LONGTEXT)

cadeh — Tue, 23 Apr 2002 16:21:04 +0000

If the create table sql isn't working then there obviously isn't going to be a messages table, so thats why the second part won't work. The create table sql you have seems to be missing a parenthesis. You need one more parenthesis at the end to close the one that started after messages(. So the end should look like:

message (longtext))

killmaster — Tue, 23 Apr 2002 06:51:54 +0000

Quote: Originally posted by mairving
Well the first thing that I would do is fix your database. Here is your code:

<?php $create = \"CREATE TABLE messages( id (int, value: 11, default: 1, auto_increment, primary) poster (text) headline (text) time(text) message (longtext) ?>

Doesn't work this is wthe whole code im using...

<?php $db = mysql_pconnect(\"localhost\",\"samcoleb_kill\",\"trustnoone\"); mysql_select_db(\"samcoleb_news\",$db); $create = \"CREATE TABLE messages( id (int, value: 11, default: 1, auto_increment, primary) poster (text) headline (text) time(text) message (longtext) ;\"; mysql_query($create); ?>

this is what I get when I try and view the news
[b]
Table 'samcoleb_news.messages' doesn't exist

http://157.238.47.212/admin/displaynews.php

killmaster — Tue, 23 Apr 2002 06:36:11 +0000

giv eme a sec and I will let you know

cadeh — Tue, 23 Apr 2002 06:32:23 +0000

Hey killmaster,

I looked at common.php and your display news page. Looks like your missing two lines of php code.

Try this in your display news code.

include("common.php");
$sql = "Select * From messages Limit 0,5";
$result = mysql_query($sql) OR die(mysql_error());
while($n = mysql_fetch_array($result)) {

That should select your last 5 inserted messages. If you want more just make the 5 into something bigger.

killmaster — Tue, 23 Apr 2002 05:32:57 +0000

hmm thanks for that I will fix the add database code of it
as for the problems I will get back to you on that one gtg be back tommorrow

thanks

mairving — Mon, 22 Apr 2002 16:12:15 +0000

Well the first thing that I would do is fix your database. Here is your code:

<?php
$create = \"CREATE TABLE messages( id (int, value: 11, default: 1, auto_increment, primary) 
poster (text) 
headline (text) 
time(text) 
message (longtext) 
?>

Several things that I would do. One is to make the primary field, message_id instead of id. This way if you join tables, it avoids same column names. Then you really don't need a default value for the id. It will start at 1 and go up from there. I would make the headline field, probably a varchar of fixed length to prevent a too long headline or wasted space. Time doesn't need to be text either. You could make it an integer, insert the value as a Unix timestamp get you values that way. Poster should also be varchar(30-50).

I didn't really get to look at the other code. What kind of problems are you having?

killmaster — Mon, 22 Apr 2002 09:48:14 +0000

ok here is another script I have decided to create -

http://157.238.47.212/mynews.zip

Except I was wondering as I don't know what the heck is going on I was wondering if someone would be able to debug the code?

Make it work just to post and view news.
Something is also going on when I try and create the table as well but I don't know what

thanks alot for all your help

killmaster — Mon, 22 Apr 2002 05:32:32 +0000

this is the code in the common.php file

<?php
$db = mysql_connect(\"localhost\",\"samcoleb_kill\",\" *** \"); 
mysql_select_db(\"samcoleb_news\",$db);
?>

this is the database connection code in which then I will only have to change one file instead of all if it needs to be updated