Gil — Wed, 15 Dec 1999 03:22:00 +0000

I have to agree with Jaffy here for the most part. Here is my version of it.

code:

sub1
{
my $hash = (
a => val,
b => val2,
c => val3
);
sub2(%hash);
}

sub 2
{
my %hash = @_;
do (something with %hash);
}
[/code]

You're free to go from here. What japhy did with the while loop was assign each key and value a scalar so that you could use them individually. This may not be want you want to do.




[This message has been edited by Gil (edited 14 December 1999).]

japhy — Tue, 14 Dec 1999 21:06:00 +0000

Malte, actually, I beg to differ, because his solution has one line that I find just as inefficient as what I did:

code:

sub1 {
  &sub2({%array});  # THIS HERE
}

sub2 {
  *newarray = shift;
  for (keys %newarray) {
    print $newarray{$_};
  }
}[/code]

I definitely agree that the typeglobbing is nice, but the line I have a problem with is your sub1() function.  By saying {%hash} instead of \%hash, you are effectively copying the elements, and for a big hash, this can be slow.  {%hash} creates a reference to an anonymous hash, whose contents are the same as %hash's, but \%hash creates a direct reference to %hash.

Also, while we're on the topic of style, perhaps the for-loop should be substituted by a while-loop, using the each() function; this is also faster, because keys %hash returns a lengthy list for big hashes.

I offer this solution:

code:sub func1 {
  my %hash;
  # populate %hash somehow
  func2(\%hash);
}

sub func2 {
  local *hash = shift;
  my ($k,$v);
  while (($k,$v) = each %hash) {
    # do whatever
  }
}[/code]

For those interested, I've posted a benchmark online at http://www.pobox.com/~japhy/tmp/perl/bm.txt 

That's all for now.

------------------
-- 
MIDN 4/C PINYAN, NROTCURPI, USNR

Malte — Tue, 14 Dec 1999 20:35:00 +0000

Froma perl style point of view Fred's answer is the better and much much faster solution.

You might also find a way doing this using objects.

Take a look a the perlob man page

Later,

Malte

------------------
Malte Ubl - www.Boardzilla.org
Communication: public<->programmers
of the Boardzilla BB

japhy — Sun, 12 Dec 1999 05:14:00 +0000

The following code has been tested (this is always a good thing to do when posting answers) and works:

sub func1 {
func2(@_);
# or &func2;
# (that would probably be faster, as it
# sends the contents of @_ by default)
}

sub func2 {
my %hash = @_;
my $key;
foreach $key (keys %hash) {
print "$key => $hash{$key}\n";
}
}

Federico Carnales — Sun, 12 Dec 1999 04:23:00 +0000

Try the following code:

sub1 {
&sub2({%array});
}

sub2 {
*newarray = shift;
for (keys %newarray) {
print $newarray{$_};
}
}

Haven't tested it -- should work.

------------------
[ Web-Reviews ]
http://www.web-reviews.com/