Client website (British Interiors)

He has: 49 posts

Joined: Jul 2007

Hi all,

Can I please have some critique on this site I've built for a client.
I also would like to know if the javascripts are working in the 'kitchen' and 'conservatory' pages across all browsers.

British Interiors

Thanks for any replies in advance,

Gary

Gary

demonhale's picture

He has: 3,278 posts

Joined: May 2005

I won't critique the design just yet, but as far as the javascript question goes, the kitchen and conservatories page js works on Firefox2 on Windows XP... You need a preloader for the image though or at least a notification like "loading"... Since when you click the links theres no tactile response to tell the customer the image is loading...

He has: 49 posts

Joined: Jul 2007

Demonhale, can you please give me some ideas on how to go about setting up a "preloader".

Thanks in advance for any help given.

JeevesBond's picture

He has: 3,955 posts

Joined: Jun 2002

You could just do something like:

<script type="text/javascript">
  preload_image = new Image();

  image_url = new Array();
  image_url[0] = 'images/img0.png';
  image_url[1] = 'images/img1.png';
  image_url[2] = 'images/img2.png';
  image_url[3] = 'images/img3.png';

  var i = 0;
  for(i=0; i<=image_url.length; i++) {
    preload_image.src = image_url[i];
  }

Give that a try. Smiling

a Padded Cell our articles site!

demonhale's picture

He has: 3,278 posts

Joined: May 2005

You can use a simple javascript call on your html, its more of a preload "trick" though.

&lt;script language="Javascript"&gt;
   Image Links here
&lt;/script&gt;

For some great examples and quick implementation, you can take a look here:

http://www.dynamicdrive.com/dynamicindex4/preloadimage.htm

Oh and theres a lot more there too, just take the time to read and choose the best for your needs...

JeevesBond's picture

He has: 3,955 posts

Joined: Jun 2002

Now for a critique: this is a nice site. The code is good, CSS + HTML used to good effect. Javascript does seem to work in all browsers, only problem you'll have is if a user has Javascript is switched off, that would take a rewrite to fix though. Generally, like formatting, Javascript shouldn't be included in HTML.

The design is alright, but some things don't seem to align very well. Did you use a grid when designing the site? It does seem well balanced though, not too left or right heavy. I love the tie-in between the sidebar menu and the header background: nice touch. Smiling

There seem to be too many lines to divide the content up. If you use a good grid, these aren't necessary. Those blue borders around everything and the heavy, blue box around the sidebar should be removed or changed. Also you don't need the dashed vertical border between the text and images on the home page. Generally I think the design gets in the way of the content it's meant to present, and should be simplified. The images on the home page are good though, they balance the design and being angled quirkily draws the eye (in a good way).

I think the text seems to be hiding from itself a little in this design. Try making it darker (as on the 'Our Services' page), then aligning the B (from 'British Interiors') with the F (from 'For all enquiries [...]'), make the content header text align with B and F, and finally align the body text with the B, F and content header. If this is confusing: just align all the text, from the logo through to the main content, this will make everything look a lot more cohesive. Smiling

One problem with the Kitchens page is the number of fonts, using more than two fonts on a page is a no-no. It makes the content look jumbled and confusing. There seem to be four different fonts in use on this page. Sad

Am not sure about the Union Jack in the logo. That bevel-ish, gradient effect is a real turn-off! It embodies a problem with the whole design: it's a bit wishy-washy. Far too many curved corners and pastel colours, trying to disguise everything being put in lots of boxes. Content should be seperated by space, colour and typeface, not boxes. Smiling

Sorry if this sounds disparaging, I actually really like your work. Bottom line: this site is of professional grade and it will make your client happy. There's always room for improvement though (and I'm not perfect!).

a Padded Cell our articles site!

He has: 49 posts

Joined: Jul 2007

Thanks for your critique JeevesBond. I have not been using grids as yet, but I certainly will look into it.

I have made the text on the contact page darker.

Demonhale wrote;

<script language="Javascript">

"Image Links here"

</script>

Any idea what the script would be for the image links?

Thanks again for your indepth critique, and thanks to everyone else who commented.

Gary

JeevesBond's picture

He has: 3,955 posts

Joined: Jun 2002

Glad you liked the critique. Just one more thing: the Union Jack should really load a picture of The Queen, a pork pie, some Wensleydale or something, I was disappointed when it loaded the home page. Laughing out loud

a Padded Cell our articles site!

demonhale's picture

He has: 3,278 posts

Joined: May 2005

graisbeck, look at jeevesbonds sample, it looks that way. Although I still advise you to go to the link I provided so you can learn more...

He has: 49 posts

Joined: Jul 2007

Ha Ha JeevesBond, if only!!!, only prob there is I wouldn't of received payment from my client.

demonhale - will do.

Thanks again,

They have: 4 posts

Joined: Jan 2008

The bottom of the page has some misplaced txt, I'm using IE 7

johneva's picture

They have: 15 posts

Joined: Jan 2008

Its a nice simple site code really clean, not much to comment on really cos there aint really anything wrong with it.

I am not quite sure about the colours used they dont seem to give it a very professional look but otherwise I am really stuck for anything mcu to comment on.

Want to join the discussion? Create an account or log in if you already have one. Joining is fast, free and painless! We’ll even whisk you back here when you’ve finished.